Max_mcu_duration missing from pwm_cycle_time

Out of curiosity, is there a reason why the max_mcu_duration feature is missing frok the pwm_cycle_time module(from my understanding, max_mcu_duration is a safety feature in case the mcu enters an error state, to keep pins from staying on).
Also why are there now 2 ways of setting up a pwm capable output pin?(output_pin and pwm_tool), is there any significant difference between those two?

And lastly, I think the naming scheme of “pwm_tool” and “pwm_cycle_time” is not that good, imo “pwm_pin” would make it a bit clearer what the module does(I also think, having both these modules is overkill and makes it way harder for the user to decide which to use, I at least can’t think of a use case for pwm_tool when I have pwm_cycle_time[except for the max_mcu_duration but I still think that should be implemented in all output_pin types)

See Pull requests · Klipper3d/klipper · GitHub

ok, this answers some of my questions, thx :slight_smile:
I still think that max_mcu duration should be implemented for pwm_cycle_time as well and also not deprecated for output_pin as it is a safety measure

This topic was automatically closed 60 days after the last reply. New replies are no longer allowed.