Found a bug in exclude_object.py

TypQxQ · November 20, 2023, 10:30pm

gcmd.respond_error() doesn’t exist. The private command gcmd._respond_error() with an underscore exists but should not be used? Any reason why it’s private?

github.com

Klipper3d/klipper/blob/187cc2f1b89e3870d694f8db6a64b116992106b7/klippy/extras/exclude_object.py#L237


      
          
                  else:
                      self.excluded_objects = []
          
              elif name:
                  if name.upper() not in self.excluded_objects:
                      self._exclude_object(name.upper())
          
              elif current:
                  if not self.current_object:
                      gcmd.respond_error('There is no current object to cancel')
          
                  else:
                      self._exclude_object(self.current_object)
          
              else:
                  self._list_excluded_objects(gcmd)
          
          cmd_EXCLUDE_OBJECT_DEFINE_help = "Provides a summary of an object"
          def cmd_EXCLUDE_OBJECT_DEFINE(self, gcmd):
              reset = gcmd.get('RESET', None)

/Andrei

flowerysong · November 21, 2023, 6:34pm

It should raise an error instead. gcode: Don't export respond_error() · Klipper3d/klipper@6152454 · GitHub

TypQxQ · November 22, 2023, 5:33am

That is right. I made a pull request for bugfix.

Topic		Replies	Views
FR - Unexcluded from exclude object - currently no way to correct a mistake Features	1	329	September 15, 2022
Exclude Object via klipperscreen General Discussion	5	246	February 20, 2024
How to generate custom message in klipper after G Code execution General Discussion	4	241	December 4, 2023
Bug: Unabe to build docs on python 3.11 or greater Developers	1	290	November 17, 2023
Request 'gcode/script' pending General Discussion	3	213	January 26, 2023

Found a bug in exclude_object.py

Related Topics